chia7712 commented on code in PR #16824:
URL: https://github.com/apache/kafka/pull/16824#discussion_r1792901017
##########
test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/ClusterConfig.java:
##########
@@ -137,11 +140,11 @@ public Map<String, String> saslClientProperties() {
}
public SecurityProtocol securityProtocol() {
- return securityProtocol;
+ return brokerSecurityProtocol;
}
- public Optional<String> listenerName() {
- return Optional.ofNullable(listenerName);
+ public ListenerName listenerName() {
Review Comment:
Could you please align the naming?
##########
test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/ClusterConfig.java:
##########
@@ -137,11 +140,11 @@ public Map<String, String> saslClientProperties() {
}
public SecurityProtocol securityProtocol() {
Review Comment:
Could you please align the naming?
##########
test-common/src/main/java/org/apache/kafka/common/test/TestKitNodes.java:
##########
@@ -39,10 +40,12 @@
import java.util.stream.IntStream;
import java.util.stream.Stream;
+@SuppressWarnings("NPathComplexity")
public class TestKitNodes {
public static final int CONTROLLER_ID_OFFSET = 3000;
public static final int BROKER_ID_OFFSET = 0;
+ public static final String DEFAULT_BROKER_LISTENER_NAME = "EXTERNAL";
Review Comment:
Could you please also add `DEFAULT_BROKER_SECURITY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
