m1a2st commented on code in PR #17498:
URL: https://github.com/apache/kafka/pull/17498#discussion_r1799577667
##########
clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java:
##########
@@ -103,14 +103,47 @@ private static void schemaToFieldTableHtml(Schema schema,
StringBuilder b) {
b.append("<th>Description</th>\n");
b.append("</tr>");
for (BoundField field : fields) {
- b.append("<tr>\n");
- b.append("<td>");
- b.append(field.def.name);
- b.append("</td>");
- b.append("<td>");
- b.append(field.def.docString);
- b.append("</td>");
- b.append("</tr>\n");
+ if (!(field.def.type instanceof TaggedFields)) {
Review Comment:
Hello @AndrewJSchofield, Thanks for your PR.
Leave a small suggestion: using POSITIVE logic here should be better than
using NEGATIVE logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
