FrankYang0529 commented on code in PR #17411:
URL: https://github.com/apache/kafka/pull/17411#discussion_r1800893278
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -378,11 +378,17 @@ private void onErrorResponse(final R response, final long
currentTimeMs) {
case INVALID_REQUEST:
case GROUP_MAX_SIZE_REACHED:
case UNSUPPORTED_ASSIGNOR:
- case UNSUPPORTED_VERSION:
logger.error("{} failed due to {}: {}",
heartbeatRequestName(), error, errorMessage);
handleFatalFailure(error.exception(errorMessage));
break;
+ case UNSUPPORTED_VERSION:
+ message = "The cluster doesn't yet support the new consumer
group protocol." +
+ " Set group.protocol=classic to revert to the classic
protocol until the cluster is upgraded.";
+ logger.error("{} failed due to {}: {}",
heartbeatRequestName(), error, message);
Review Comment:
Yes, we give user message in the exception (the assertion in test case), so
we don't need to log it here. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
