kamalcph commented on code in PR #16602:
URL: https://github.com/apache/kafka/pull/16602#discussion_r1801520658
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -263,6 +270,10 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
);
}
+ public void
setDelayedOperationPurgatory(DelayedOperationPurgatory<DelayedRemoteListOffsets>
delayedRemoteListOffsetsPurgatory) {
+ this.delayedRemoteListOffsetsPurgatory =
delayedRemoteListOffsetsPurgatory;
Review Comment:
Added the `volatile` to the delayedRemoteListOffsetsPurgatory in
RemoteLogManager. My understanding was that we instantiate the
[dataPlaneRequestProcessor](https://sourcegraph.com/github.com/apache/kafka/-/blob/core/src/main/scala/kafka/server/KafkaServer.scala?L604-608)
after calling the
[ReplicaManager#startup](https://sourcegraph.com/github.com/apache/kafka/-/blob/core/src/main/scala/kafka/server/ReplicaManager.scala?L418),
so there won't be an issue. It is good to be on the safer side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
