satishd commented on code in PR #17499:
URL: https://github.com/apache/kafka/pull/17499#discussion_r1804119567
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -257,13 +257,13 @@ public static ConfigDef configDef() {
atLeast(1),
MEDIUM,
REMOTE_LOG_MANAGER_THREAD_POOL_SIZE_DOC)
-
.defineInternal(REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP,
+ .define(REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP,
INT,
DEFAULT_REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE,
Review Comment:
+1 not to break backward compatibility here.
But it is better to go with default value as -1 and the validation can be -1
or >0.
We can clarify the doc adding with the below text for better clarity.
"The default value of -1 means that this will be set to the configured value
of `remote.log.manager.thread.pool.size`, if available; otherwise, it defaults
to 10" .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
