apoorvmittal10 commented on code in PR #17519:
URL: https://github.com/apache/kafka/pull/17519#discussion_r1804734544
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1221,7 +1206,7 @@ private[kafka] class Processor(
private def processDisconnected(): Unit = {
selector.disconnected.keySet.forEach { connectionId =>
try {
- val remoteHost = ConnectionId.fromString(connectionId).getOrElse {
+ val remoteHost =
ServerConnectionId.fromString(connectionId).orElseThrow { () =>
throw new IllegalStateException(s"connectionId has unexpected
format: $connectionId")
Review Comment:
I was trying to maintain least refactor while keeping original context. I ll
look into this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
