bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1804849291
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4134,6 +4150,22 @@ private KafkaFutureImpl<List<MemberIdentity>>
getMembersFromGroup(String groupId
return future;
}
+ @Override
+ public void registerMetricForSubscription(KafkaMetric metric) {
+ if (clientTelemetryReporter.isPresent()) {
+ ClientTelemetryReporter reporter = clientTelemetryReporter.get();
+ reporter.metricChange(metric);
Review Comment:
I don't feel this is an issue, for the following reason.
The `ClientTelemetryReporter.metricChange` delegates the metric to the
`KafkaMetricsCollector`. In the
[KafkaMetricsCollector.collectMetric](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java#L202-L220)
method, it evaluates each metric to ensure it is the expected type. If it's no
a log.debug is issued, and the metric is dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
