m1a2st commented on code in PR #17542: URL: https://github.com/apache/kafka/pull/17542#discussion_r1806678649
########## tests/docker/Dockerfile: ########## @@ -65,7 +65,8 @@ LABEL ducker.creator=$ducker_creator RUN apt update && apt install -y sudo git netcat iptables rsync unzip wget curl jq coreutils openssh-server net-tools vim python3-pip python3-dev libffi-dev libssl-dev cmake pkg-config libfuse-dev iperf traceroute iproute2 iputils-ping && apt-get -y clean RUN python3 -m pip install -U pip==21.1.1; # NOTE: ducktape 0.12.0 supports py 3.9, 3.10, 3.11 and 3.12 -RUN pip3 install --upgrade cffi virtualenv pyasn1 boto3 pycrypto pywinrm ipaddress enum34 debugpy psutil && pip3 install --upgrade "ducktape==0.12.0" Review Comment: In python3.4 already contained the enum module, [doc](https://www.python.org/downloads/release/python-340/), so in this change I doesn;t move it to the `requirements.txt` ########## tests/docker/Dockerfile: ########## @@ -65,7 +65,8 @@ LABEL ducker.creator=$ducker_creator RUN apt update && apt install -y sudo git netcat iptables rsync unzip wget curl jq coreutils openssh-server net-tools vim python3-pip python3-dev libffi-dev libssl-dev cmake pkg-config libfuse-dev iperf traceroute iproute2 iputils-ping && apt-get -y clean RUN python3 -m pip install -U pip==21.1.1; # NOTE: ducktape 0.12.0 supports py 3.9, 3.10, 3.11 and 3.12 -RUN pip3 install --upgrade cffi virtualenv pyasn1 boto3 pycrypto pywinrm ipaddress enum34 debugpy psutil && pip3 install --upgrade "ducktape==0.12.0" Review Comment: In python3.4 already contained the enum module, [doc](https://www.python.org/downloads/release/python-340/), so in this change I don't move it to the `requirements.txt` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
