junrao commented on code in PR #17534:
URL: https://github.com/apache/kafka/pull/17534#discussion_r1806849633
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -184,30 +172,28 @@ private SharePartitionManager(
GroupConfigManager groupConfigManager,
Metrics metrics
) {
- this.replicaManager = replicaManager;
- this.time = time;
- this.cache = cache;
- this.partitionCacheMap = partitionCacheMap;
- this.fetchQueue = new ConcurrentLinkedQueue<>();
- this.processFetchQueueLock = new AtomicBoolean(false);
- this.defaultRecordLockDurationMs = defaultRecordLockDurationMs;
- this.timer = new SystemTimerReaper("share-group-lock-timeout-reaper",
- new SystemTimer("share-group-lock-timeout"));
- this.maxDeliveryCount = maxDeliveryCount;
- this.maxInFlightMessages = maxInFlightMessages;
- this.persister = persister;
- this.groupConfigManager = groupConfigManager;
- this.shareGroupMetrics = new
ShareGroupMetrics(Objects.requireNonNull(metrics), time);
+ this(
+ replicaManager,
Review Comment:
merge with previous line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
