apoorvmittal10 commented on code in PR #17322:
URL: https://github.com/apache/kafka/pull/17322#discussion_r1808345845
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -612,16 +634,20 @@ public List<AcquiredRecords> acquire(
.setFirstOffset(inFlightBatch.firstOffset())
.setLastOffset(inFlightBatch.lastOffset())
.setDeliveryCount((short)
inFlightBatch.batchDeliveryCount()));
+ acquiredCount += (int) (inFlightBatch.lastOffset() -
inFlightBatch.firstOffset() + 1);
Review Comment:
Yeah, but server can't determine that as we do not read the records content
in server. Rather clients inform for any gaps in the record batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
