chia7712 commented on code in PR #16965:
URL: https://github.com/apache/kafka/pull/16965#discussion_r1811204610
##########
build.gradle:
##########
@@ -113,11 +113,22 @@ ext {
commitId = determineCommitId()
- addParametersForTests = { name, options ->
+ configureJavaCompiler = { name, options ->
// -parameters generates arguments with parameter names in
TestInfo#getDisplayName.
// ref:
https://github.com/junit-team/junit5/blob/4c0dddad1b96d4a20e92a2cd583954643ac56ac0/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java#L161-L164
- if (name == "compileTestJava" || name == "compileTestScala")
+ if (name == "compileTestJava" || name == "compileTestScala") {
options.compilerArgs << "-parameters"
+ } else if (name == "compileJava" || name == "compileScala") {
+ options.compilerArgs << "-Xlint:all"
+ if (!project.path.startsWith(":connect") &&
!project.path.startsWith(":storage"))
+ options.compilerArgs << "-Xlint:-rawtypes"
+ options.compilerArgs << "-encoding" << "UTF-8"
+ options.compilerArgs << "-Xlint:-rawtypes"
Review Comment:
duplicate config?
##########
clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java:
##########
@@ -122,7 +122,7 @@ void testNeverExpiringX509Certificate() throws Exception {
wrappedCert.hasUnsupportedCriticalExtension());
// We have just generated a valid test certificate, it should
still be valid now
assertEquals(cert.getBasicConstraints(),
wrappedCert.getBasicConstraints());
- assertEquals(cert.getIssuerDN(), wrappedCert.getIssuerDN());
Review Comment:
why we need those changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
