clarkwtc commented on code in PR #17578:
URL: https://github.com/apache/kafka/pull/17578#discussion_r1815283080
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -707,7 +708,8 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
try (MetricsEmitter emitter = new
ClientTelemetryEmitter(localSubscription.selector(),
localSubscription.deltaTemporality())) {
emitter.init();
kafkaMetricsCollector.collect(emitter);
- payload = createPayload(emitter.emittedMetrics());
+ MetricsData payloadMetricsData =
createPayload(emitter.emittedMetrics());
+ payload = compressPayload(payloadMetricsData);
Review Comment:
@chia7712 Sorry, I got it the wrong way.
I replaced the original compress because it couldn't be called from other
functions.
Also rewrote related tests for using compress as testMetricsDataCompression
and testCompressDecompress.
If this change causes any side effects or if it would be better to keep the
original compress function, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
