m1a2st commented on code in PR #17594:
URL: https://github.com/apache/kafka/pull/17594#discussion_r1815359264
##########
tools/src/test/java/org/apache/kafka/tools/AbstractResetIntegrationTest.java:
##########
@@ -246,7 +244,7 @@ public void
testReprocessingFromScratchAfterResetWithoutIntermediateUserTopic(fi
final List<KeyValue<Long, Long>> resultRerun =
IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(resultConsumerConfig,
OUTPUT_TOPIC, 10);
streams.close();
- assertThat(resultRerun, equalTo(result));
+ assertEquals(resultRerun, result);
Review Comment:
This `assertEquals` statement has the expected and actual values in the
wrong order.
##########
tools/src/test/java/org/apache/kafka/tools/AbstractResetIntegrationTest.java:
##########
@@ -306,17 +304,17 @@ private void
testReprocessingFromScratchAfterResetWithIntermediateUserTopic(fina
final List<KeyValue<Long, Long>> resultRerun2 =
IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(resultConsumerConfig,
OUTPUT_TOPIC_2_RERUN, 40);
streams.close();
- assertThat(resultRerun, equalTo(result));
- assertThat(resultRerun2, equalTo(result2));
+ assertEquals(result, resultRerun);
+ assertEquals(result2, resultRerun2);
if (!useRepartitioned) {
final Properties props =
TestUtils.consumerConfig(cluster.bootstrapServers(), appID +
"-result-consumer", LongDeserializer.class, StringDeserializer.class,
commonClientConfig);
final List<KeyValue<Long, String>> resultIntermediate =
IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(props,
INTERMEDIATE_USER_TOPIC, 21);
for (int i = 0; i < 10; i++) {
- assertThat(resultIntermediate.get(i),
equalTo(resultIntermediate.get(i + 11)));
+ assertEquals(resultIntermediate.get(i),
resultIntermediate.get(i + 11));
Review Comment:
ditto This `assertEquals` statement has the expected and actual values in
the wrong order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
