frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1818349405


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -205,14 +211,24 @@ public abstract class AbstractMembershipManager<R extends 
AbstractResponse> impl
      */
     private boolean isPollTimerExpired;
 
+    /**
+     * Indicate the operation on consumer group membership that the consumer 
will perform when leaving the group.
+     * The property should remain {@code GroupMembershipOperation.DEFAULT} 
until the consumer is closing.
+     *
+     * @see GroupMembershipOperation
+     */
+    protected GroupMembershipOperation leaveGroupOperation = 
GroupMembershipOperation.DEFAULT;

Review Comment:
   Due to the architecture of the async consumer, it's difficult to pass 
`GroupMembershipOperation` directly to `AbstractMembershipManager`, so I added 
a property to hold the behavior for leaving the group, which remains unchanged 
except when the consumer is closing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to