chirag-wadhwa5 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1818411110
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -189,6 +194,176 @@ public void testMaybeInitialize() {
assertNull(sharePartition.cachedState().get(11L).offsetState());
}
+ @Test
+ public void
testMaybeInitializeDefaultStartEpochGroupConfigReturnsEarliest() {
+ Persister persister = Mockito.mock(Persister.class);
+ ReadShareGroupStateResult readShareGroupStateResult =
Mockito.mock(ReadShareGroupStateResult.class);
+
Mockito.when(readShareGroupStateResult.topicsData()).thenReturn(Collections.singletonList(
+ new TopicData<>(TOPIC_ID_PARTITION.topicId(),
Collections.singletonList(
+ PartitionFactory.newPartitionAllData(
+ 0, PartitionFactory.DEFAULT_STATE_EPOCH,
+ PartitionFactory.UNINITIALIZED_START_OFFSET,
+ PartitionFactory.DEFAULT_ERROR_CODE,
+ PartitionFactory.DEFAULT_ERR_MESSAGE,
+ Collections.emptyList())))));
+
Mockito.when(persister.readState(Mockito.any())).thenReturn(CompletableFuture.completedFuture(readShareGroupStateResult));
+
+ GroupConfigManager groupConfigManager =
Mockito.mock(GroupConfigManager.class);
+ GroupConfig groupConfig = Mockito.mock(GroupConfig.class);
+
Mockito.when(groupConfigManager.groupConfig(GROUP_ID)).thenReturn(Optional.of(groupConfig));
+
Mockito.when(groupConfig.shareAutoOffsetReset()).thenReturn(GroupConfig.ShareGroupAutoOffsetReset.EARLIEST);
+
+ ReplicaManager replicaManager = Mockito.mock(ReplicaManager.class);
+
+ FileRecords.TimestampAndOffset timestampAndOffset = new
FileRecords.TimestampAndOffset(-1L, 0L, Optional.empty());
+ Mockito.doReturn(new
OffsetResultHolder(Option.apply(timestampAndOffset), Option.empty())).
+
when(replicaManager).fetchOffsetForTimestamp(Mockito.any(TopicPartition.class),
Mockito.anyLong(), Mockito.any(), Mockito.any(), Mockito.anyBoolean());
+
+ SharePartition sharePartition = SharePartitionBuilder.builder()
+ .withPersister(persister)
+ .withGroupConfigManager(groupConfigManager)
+ .withReplicaManager(replicaManager)
+ .build();
+
+ CompletableFuture<Void> result = sharePartition.maybeInitialize();
+ assertTrue(result.isDone());
+ assertFalse(result.isCompletedExceptionally());
+
+ assertEquals(SharePartitionState.ACTIVE,
sharePartition.partitionState());
+ assertTrue(sharePartition.cachedState().isEmpty());
+ assertEquals(0, sharePartition.startOffset());
Review Comment:
Thanks for the review. Yep, I did miss this. I have added another
verification to check whether fetchOffsetForTimestamp was called with
ListOffsetsRequest.LATEST_TIMESTAMP or ListOffsetsRequest.EARLIEST_TIMESTAMP.
That should be enough to verify that the initialization is happening correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
