AndrewJSchofield commented on code in PR #17537:
URL: https://github.com/apache/kafka/pull/17537#discussion_r1818701642
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1244,8 +1244,8 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
IdAndPartition that = (IdAndPartition) o;
- return Objects.equals(topicId, that.topicId) &&
- Objects.equals(partitionIndex, that.partitionIndex);
+ return topicId == that.topicId &&
Review Comment:
Only the primitive should be compared with `==`. Uuid is not a primitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
