cmccabe commented on code in PR #17617:
URL: https://github.com/apache/kafka/pull/17617#discussion_r1819373443
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -938,9 +938,12 @@ ControllerResult<Map<Uuid, ApiError>>
deleteTopics(ControllerRequestContext cont
BoundedList.newArrayBacked(MAX_RECORDS_PER_USER_OP,
ids.size());
for (Uuid id : ids) {
try {
+ log.info("Starting deletion of topic with ID {}.", id);
deleteTopic(context, id, records);
results.put(id, ApiError.NONE);
+ log.info("Successfully deleted topic with ID {}.", id);
} catch (ApiException e) {
+ log.error("Failed to delete topic with ID {} due to API
exception.", id, e);
Review Comment:
This isn't an error. It should be at INFO level. But more importantly,
shouldn't all the topics deleted in this RPC share a single log message?
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -956,8 +959,10 @@ void deleteTopic(ControllerRequestContext context, Uuid
id, List<ApiMessageAndVe
throw new UnknownTopicIdException(UNKNOWN_TOPIC_ID.message());
}
int numPartitions = topic.parts.size();
+ log.info("Deleting topic {} with ID {} and {} partitions", topic.name,
id, numPartitions);
Review Comment:
This should be at TRACE level since most people don't care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
