msillence commented on code in PR #17510:
URL: https://github.com/apache/kafka/pull/17510#discussion_r1819229664
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -1041,6 +1043,10 @@ private static SchemaAndValue parseAsNumber(String
token) {
}
private static SchemaAndValue parseAsExactDecimal(BigDecimal decimal) {
+ BigDecimal abs = decimal.abs();
+ if (abs.compareTo(TOO_BIG) > 0 || (abs.compareTo(TOO_SMALL) < 0 &&
BigDecimal.ZERO.compareTo(abs) != 0)) {
+ throw new NumberFormatException("outside efficient parsing
range");
Review Comment:
I thought we were converting to a BigInteger at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
