ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1819719894


##########
build.gradle:
##########
@@ -2596,6 +2626,7 @@ project(':streams') {
     implementation libs.slf4jApi
     implementation libs.jacksonAnnotations
     implementation libs.jacksonDatabind
+    implementation libs.bndlib

Review Comment:
   The BND annotations are intentionally in the `provided` Maven scope of all 
Log4j artifacts, so that these annotations with `CLASS` retention do not end up 
in the runtime classpath. You can do the same and add them as `compileOnly` in 
Gradle.
   
   The compiler warnings should disappear once 
[JDK-8342833](https://bugs.openjdk.org/browse/JDK-8342833) is fixed.
   Untile then we will remove the outdated ones (see 
apache/logging-log4j2#3133) in the next Log4j release, which should remove the 
warning on `Level`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to