cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821604696
##########
tests/kafkatest/services/kafka/quorum.py:
##########
@@ -21,18 +21,18 @@
# How we will parameterize tests that exercise all quorum styles
# [“ZK”, “ISOLATED_KRAFT”, "COMBINED_KRAFT"] during the KIP-500 bridge
release(s)
# [“ISOLATED_KRAFT”, "COMBINED_KRAFT”] after the KIP-500 bridge release(s)
-all = [zk, isolated_kraft, combined_kraft]
+all = [isolated_kraft, combined_kraft]
# How we will parameterize tests that exercise all KRaft quorum styles
all_kraft = [isolated_kraft, combined_kraft]
# How we will parameterize tests that are unrelated to upgrades:
# [“ZK”] before the KIP-500 bridge release(s)
# [“ZK”, “ISOLATED_KRAFT”] during the KIP-500 bridge release(s) and in
preview releases
# [“ISOLATED_KRAFT”] after the KIP-500 bridge release(s)
-all_non_upgrade = [zk, isolated_kraft]
+all_non_upgrade = [isolated_kraft]
def for_test(test_context):
# A test uses ZooKeeper if it doesn't specify a metadata quorum or if it
explicitly specifies ZooKeeper
Review Comment:
The comment should be updated to specify that the default is
`isolated_kraft` , right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
