FrankYang0529 commented on PR #17150: URL: https://github.com/apache/kafka/pull/17150#issuecomment-2447342501
Hi @lianetm, thanks for the review. I address all comments with following update: * Move `ConsumerUtils#maybeUpdateLastSeenEpochIfNewer` to `ApplicationEventProcessor#maybeUpdateLastSeenEpochIfNewer` and do all metadata update in the background thread. * Add `testFetchCommittedOffsetsEvent` to `ApplicationEventProcessorTest`. * When `autoCommitEnabled` is `true`, using `Optional.empty` for `commitSync` function. Update `AsyncKafkaConsumerTest#testAutoCommitSyncEnabled` to check `SyncCommitEvent#offsets` is not present. * Update default auto commit enabled to false in `AsyncKafkaConsumerTest`. Before this PR, we also wait for SyncCommitEvent and we didn't mock complete SyncCommitEvent, but previous test result didn't be blocked on `close` function by the event. If the default auto commit enabled is true and the test case calls `close` function evidently, it may be blocked by SyncCommitEvent and the test case will wait for 30 seconds. I'm not sure whether the root cause is that we change the future result from `Void` to `Map<TopicPartition, OffsetAndMetadata>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
