dajac commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824442610
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -14086,16 +14123,20 @@ public void testShareGroupMemberIdGeneration() {
Collections.emptyMap()
));
+ String memberId = Uuid.randomUuid().toString();
CoordinatorResult<ShareGroupHeartbeatResponseData, CoordinatorRecord>
result = context.shareGroupHeartbeat(
new ShareGroupHeartbeatRequestData()
.setGroupId("group-foo")
+ .setMemberId(memberId)
.setMemberEpoch(0)
.setSubscribedTopicNames(Arrays.asList("foo", "bar")));
- // Verify that a member id was generated for the new member.
- String memberId = result.response().memberId();
- assertNotNull(memberId);
- assertNotEquals("", memberId);
+ assertNotNull(result.response().memberId());
Review Comment:
nit: This one is not needed because assertEquals already cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
