mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1824185851
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##########
@@ -174,43 +175,50 @@ private synchronized List<org.apache.log4j.Logger>
loggers(String namespace) {
}
// visible for testing
- org.apache.log4j.Logger lookupLogger(String logger) {
+ org.apache.logging.log4j.Logger lookupLogger(String logger) {
return LogManager.getLogger(logger);
}
- @SuppressWarnings("unchecked")
- // visible for testing
- Enumeration<org.apache.log4j.Logger> currentLoggers() {
- return LogManager.getCurrentLoggers();
+ List<org.apache.logging.log4j.Logger> currentLoggers() {
+ LoggerContext context = (LoggerContext) LogManager.getContext(false);
+ Collection<LoggerConfig> loggerConfigs =
context.getConfiguration().getLoggers().values();
+ Set<String> loggerNames = loggerConfigs.stream()
+ .map(LoggerConfig::getName)
+ .collect(Collectors.toSet());
+
+ List<org.apache.logging.log4j.Logger> loggers = new ArrayList<>();
+ for (String name : loggerNames) {
+ loggers.add(LogManager.getLogger(name));
+ }
+ return loggers;
}
// visible for testing
- org.apache.log4j.Logger rootLogger() {
+ org.apache.logging.log4j.Logger rootLogger() {
return LogManager.getRootLogger();
}
- private void setLevel(org.apache.log4j.Logger logger, Level level) {
- Level currentLevel = logger.getLevel();
- if (currentLevel == null)
- currentLevel = logger.getEffectiveLevel();
+ private void setLevel(org.apache.logging.log4j.Logger logger, Level level)
{
+ String loggerName = logger.getName();
+ LoggerContext context = (LoggerContext) LogManager.getContext(false);
+ LoggerConfig loggerConfig =
context.getConfiguration().getLoggerConfig(loggerName);
+ Level currentLevel = loggerConfig.getLevel();
Review Comment:
This is used by Kafka Connect. We have a REST API that allows changing the
log level of all instances in a Kafka Connect cluster. See
https://cwiki.apache.org/confluence/display/KAFKA/KIP-495%3A+Dynamically+Adjust+Log+Levels+in+Connect
for the details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
