chia7712 commented on code in PR #17613:
URL: https://github.com/apache/kafka/pull/17613#discussion_r1825895125
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/OAuthBearerSaslClientProvider.java:
##########
@@ -25,14 +25,14 @@
public class OAuthBearerSaslClientProvider extends Provider {
private static final long serialVersionUID = 1L;
- @SuppressWarnings("this-escape")
- protected OAuthBearerSaslClientProvider() {
+ private OAuthBearerSaslClientProvider() {
Review Comment:
Could you please use `final` to fix it?
##########
clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainSaslServerProvider.java:
##########
@@ -25,13 +25,13 @@ public class PlainSaslServerProvider extends Provider {
private static final long serialVersionUID = 1L;
- @SuppressWarnings("this-escape")
- protected PlainSaslServerProvider() {
Review Comment:
ditto
##########
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslServerProvider.java:
##########
@@ -25,14 +25,14 @@ public class ScramSaslServerProvider extends Provider {
private static final long serialVersionUID = 1L;
- @SuppressWarnings("this-escape")
- protected ScramSaslServerProvider() {
Review Comment:
ditto
##########
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClientProvider.java:
##########
@@ -25,14 +25,14 @@ public class ScramSaslClientProvider extends Provider {
private static final long serialVersionUID = 1L;
- @SuppressWarnings("this-escape")
- protected ScramSaslClientProvider() {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
