cmccabe commented on code in PR #17684:
URL: https://github.com/apache/kafka/pull/17684#discussion_r1829724023
##########
generator/src/main/java/org/apache/kafka/message/checker/MetadataSchemaCheckerTool.java:
##########
@@ -81,8 +103,18 @@ public static void run(
", and path2: " + path2);
break;
}
+ case "verify-evolution-git": {
+ String fileCheckMetadata = namespace.getString("file");
+ String gitContent = GetDataFromGit(fileCheckMetadata);
+ EvolutionVerifier verifier = new EvolutionVerifier(
+
CheckerUtils.readMessageSpecFromFile(Paths.get("").toAbsolutePath().getParent()
+ "/metadata/src/main/resources/common/metadata/" + fileCheckMetadata),
Review Comment:
in general I don't understand what the strategy is here for paths. if you
are using a relative path, you need to document what directory we need to be
in. how are we locating the git repository root?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
