junrao commented on code in PR #17636:
URL: https://github.com/apache/kafka/pull/17636#discussion_r1831500139
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1014,12 +1015,12 @@ class ReplicaManager(val config: KafkaConfig,
val delayedProduce = new DelayedProduce(timeoutMs, produceMetadata,
this, responseCallback, delayedProduceLock)
// create a list of (topic, partition) pairs to use as keys for this
delayed produce operation
- val producerRequestKeys =
entriesPerPartition.keys.map(TopicPartitionOperationKey(_)).toSeq
+ val producerRequestKeys = entriesPerPartition.keys.map(new
TopicPartitionOperationKey(_)).toSeq
Review Comment:
Is this comment addressed? I still see a mix of `toSeq` and `toList`.
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -93,7 +94,7 @@ class ZkAdminManager(val config: KafkaConfig,
* Try to complete delayed topic operations with the request key
*/
def tryCompleteDelayedTopicOperations(topic: String): Unit = {
- val key = TopicKey(topic)
+ val key = new TopicKey(topic)
Review Comment:
No need for `new`. Ditto in a few other places below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
