mjsax commented on code in PR #17245:
URL: https://github.com/apache/kafka/pull/17245#discussion_r1833274382
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -1576,139 +1562,49 @@ public void
shouldProcessFromSourcesThatMatchMultiplePattern() {
}
@Test
- @SuppressWarnings("deprecation")
- public void shouldNotAllowBadTransformerSupplierOnFlatTransform() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcess() {
Review Comment:
Is there no existing test for `ProcessSupplier` to test test case? Just
wondering if this rewrite makes sense (and closes a test gap), or if this
rewrite would duplicate an existing test (and thus, we could just remove this
test instead of rewriting it)?
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -1576,139 +1562,49 @@ public void
shouldProcessFromSourcesThatMatchMultiplePattern() {
}
@Test
- @SuppressWarnings("deprecation")
- public void shouldNotAllowBadTransformerSupplierOnFlatTransform() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcess() {
+ final org.apache.kafka.streams.processor.api.Processor<String, String,
Void, Void> processor =
+ processorSupplier.get();
final IllegalArgumentException exception = assertThrows(
IllegalArgumentException.class,
- () -> testStream.flatTransform(() -> transformer)
+ () -> testStream.process(() -> processor)
);
assertThat(exception.getMessage(), containsString("#get() must return
a new object each time it is called."));
}
@Test
- @SuppressWarnings("deprecation")
- public void
shouldNotAllowBadTransformerSupplierOnFlatTransformWithStores() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcessWithStores() {
+ final org.apache.kafka.streams.processor.api.Processor<String, String,
Void, Void> processor =
+ processorSupplier.get();
final IllegalArgumentException exception = assertThrows(
IllegalArgumentException.class,
- () -> testStream.flatTransform(() -> transformer, "storeName")
+ () -> testStream.process(() -> processor, "storeName")
);
assertThat(exception.getMessage(), containsString("#get() must return
a new object each time it is called."));
}
@Test
- @SuppressWarnings("deprecation")
- public void shouldNotAllowBadTransformerSupplierOnFlatTransformWithNamed()
{
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcessWithNamed() {
+ final org.apache.kafka.streams.processor.api.Processor<String, String,
Void, Void> processor =
+ processorSupplier.get();
final IllegalArgumentException exception = assertThrows(
IllegalArgumentException.class,
- () -> testStream.flatTransform(() -> transformer,
Named.as("flatTransformer"))
+ () -> testStream.process(() -> processor,
Named.as("flatTransformer"))
);
assertThat(exception.getMessage(), containsString("#get() must return
a new object each time it is called."));
}
@Test
- @SuppressWarnings("deprecation")
- public void
shouldNotAllowBadTransformerSupplierOnFlatTransformWithNamedAndStores() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcessWithNamedAndStores() {
Review Comment:
as above
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -1576,139 +1562,49 @@ public void
shouldProcessFromSourcesThatMatchMultiplePattern() {
}
@Test
- @SuppressWarnings("deprecation")
- public void shouldNotAllowBadTransformerSupplierOnFlatTransform() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcess() {
+ final org.apache.kafka.streams.processor.api.Processor<String, String,
Void, Void> processor =
+ processorSupplier.get();
final IllegalArgumentException exception = assertThrows(
IllegalArgumentException.class,
- () -> testStream.flatTransform(() -> transformer)
+ () -> testStream.process(() -> processor)
);
assertThat(exception.getMessage(), containsString("#get() must return
a new object each time it is called."));
}
@Test
- @SuppressWarnings("deprecation")
- public void
shouldNotAllowBadTransformerSupplierOnFlatTransformWithStores() {
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcessWithStores() {
+ final org.apache.kafka.streams.processor.api.Processor<String, String,
Void, Void> processor =
+ processorSupplier.get();
final IllegalArgumentException exception = assertThrows(
IllegalArgumentException.class,
- () -> testStream.flatTransform(() -> transformer, "storeName")
+ () -> testStream.process(() -> processor, "storeName")
);
assertThat(exception.getMessage(), containsString("#get() must return
a new object each time it is called."));
}
@Test
- @SuppressWarnings("deprecation")
- public void shouldNotAllowBadTransformerSupplierOnFlatTransformWithNamed()
{
- final org.apache.kafka.streams.kstream.Transformer<String, String,
Iterable<KeyValue<String, String>>> transformer = flatTransformerSupplier.get();
+ public void shouldNotAllowBadProcessSupplierOnProcessWithNamed() {
Review Comment:
same question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
