mjsax commented on code in PR #17710:
URL: https://github.com/apache/kafka/pull/17710#discussion_r1833595738
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -248,18 +251,54 @@ private static StreamsConfig createConfig(final String
enforcedProcessingValue)
}
private static StreamsConfig createConfig(final String eosConfig, final
String enforcedProcessingValue) {
- return createConfig(eosConfig, enforcedProcessingValue,
LogAndFailExceptionHandler.class.getName(),
LogAndFailProcessingExceptionHandler.class.getName());
+ return createConfig(
+ eosConfig,
+ enforcedProcessingValue,
+ LogAndFailExceptionHandler.class,
+ LogAndFailProcessingExceptionHandler.class,
+ FailOnInvalidTimestamp.class
+ );
+ }
+
+ private static StreamsConfig createConfig(final Class<? extends
DeserializationExceptionHandler> deserializationExceptionHandler) {
+ return createConfig(
+ AT_LEAST_ONCE,
+ "0",
+ deserializationExceptionHandler,
+ LogAndFailProcessingExceptionHandler.class,
+ FailOnInvalidTimestamp.class
+ );
+ }
+
+ private static StreamsConfig createConfigWithTsExtractor(final Class<?
extends TimestampExtractor> timestampExtractor) {
+ return createConfig(
+ AT_LEAST_ONCE,
Review Comment:
Why would we want to run this test with EOS? This helper is only used for
the new test of this PR. I don't see any reason why we should run the test with
EOS? (In the end, the alos/eos config does not really matter, but given the
helper overloads we have, we need to pass in something if we don't want to get
too many overloads.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
