FrankYang0529 commented on code in PR #17673:
URL: https://github.com/apache/kafka/pull/17673#discussion_r1835569444
##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -38,15 +38,9 @@ def setUp(self):
self.zk.start()
@cluster(num_nodes=5)
- # We are keeping 0.8.2 here so that we don't inadvertently break support
for it. Since this is just a sanity check,
- # the overhead should be manageable.
- @parametrize(version=str(LATEST_0_8_2), new_consumer=False)
- @parametrize(version=str(LATEST_0_9), new_consumer=False)
- @parametrize(version=str(LATEST_0_9))
- @parametrize(version=str(LATEST_1_1), new_consumer=False)
- @cluster(num_nodes=5)
+ @parametrize(version=str(LATEST_2_1), new_consumer=False)
@matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all)
Review Comment:
If we only apply this change on trunk branch, we also get same error. The
reason is that `last` is `None`.
```
last = None
for line in node.account.ssh_capture(cmd):
last = line
# Parse and save the last line's information
self.results[idx-1] = self.parse_results(last, node.version)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
