dajac commented on PR #17255: URL: https://github.com/apache/kafka/pull/17255#issuecomment-2468626763
> I got this thing as we do not have the updated state in the close method and we may need to perform some operation like electing and revoking a task as leader based on a certain partition it has. I don't understand this part. Based on the subscription state and the revoked partitions that the callback received, it should be possible to compute the remaining list. Have you considered it? My concern with the change is that it may break existing use cases. For instance, it is pretty common to call Consumer.commitSync in the revoke callback. commitSync commits based on the subscription state so if we remove partitions before it won't commit the offsets of the revoked partitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
