apoorvmittal10 opened a new pull request, #17796: URL: https://github.com/apache/kafka/pull/17796
### Note: I haven't added tests yet and plan to do once get confirmation on the approach, however tested manually with multi broker setup. The PR adds listeners to Partition class which might invoke the clean up of share partitions on Partition changes. I considered introducing new Listener class which defines methods per SharePartitionKey but avoided as that would have required wiring up at the calls at different places in ReplicaManager. Additionally replica manager needed handling to store the new listener, etc. I found the current PR approach better as SharePartition is abstracted Shared view of Partition hence attaching the change events on Partition is helpful. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
