mumrah commented on code in PR #17725:
URL: https://github.com/apache/kafka/pull/17725#discussion_r1841352202
##########
.github/scripts/junit.py:
##########
@@ -171,11 +172,12 @@ def parse_report(workspace_path, report_path, fp) ->
Iterable[TestSuite]:
elif elem.tag == "skipped":
skipped = partial_test_case(None, None, None)
cur_suite.skipped_tests.append(skipped)
+ test_case_skipped = True
else:
pass
elif event == "end":
if elem.tag == "testcase":
- if not test_case_failed:
+ if not test_case_failed and not test_case_skipped:
Review Comment:
This was a bug where skipped tests were considered as passed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
