apoorvmittal10 commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1842972918
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -127,7 +127,7 @@ public void onComplete() {
shareFetchData.future().complete(result);
} catch (Exception e) {
log.error("Error processing delayed share fetch request", e);
- shareFetchData.future().completeExceptionally(e);
+
sharePartitionManager.handleFetchException(shareFetchData.groupId(),
topicPartitionData.keySet(), shareFetchData.future(), e);
Review Comment:
@junrao I think the error from LogReadResult is already handled as we set
the respective partition level error while parsing response in
ShareFetchUtils.processFetchResponse method. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
