junrao commented on code in PR #17739:
URL: https://github.com/apache/kafka/pull/17739#discussion_r1844294705
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -91,39 +90,47 @@ public void onExpiration() {
*/
@Override
public void onComplete() {
+ // We are utilizing lock so that onComplete doesn't do a dirty read
for global variables -
Review Comment:
There are instance variables, not global.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
