bbejeck commented on code in PR #17820:
URL: https://github.com/apache/kafka/pull/17820#discussion_r1844572343
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -614,6 +615,12 @@ public StreamThread(final Time time,
streamsMetrics,
time.milliseconds()
);
+ ThreadMetrics.addThreadStateTelemetryMetric(threadId,
+ streamsMetrics,
+ (metricConfig, now) -> this.state().ordinal());
+ ThreadMetrics.addThreadStateMetric(threadId,
+ streamsMetrics,
+ (metricConfig, now) ->
this.state().name().toLowerCase(Locale.getDefault()));
Review Comment:
The KIP specifies lower-case string but I like the other approach so I'll
update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
