divijvaidya commented on code in PR #17840:
URL: https://github.com/apache/kafka/pull/17840#discussion_r1846165837
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1543,6 +1547,76 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
assertNull(returnedOffsets.get(topicPartition))
}
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly"))
+ def testDeleteRecordsAfterCorruptRecords(quorum: String, groupProtocol:
String): Unit = {
Review Comment:
I am a bit worried about `PlaintextAdminIntegrationTest.scala` becoming a
very large class with varied different kinds of tests. Having said that, many
other DeleteRecords tests reside here currently, so it is ok to add this one.
The refactoring of `PlaintextAdminIntegrationTest` can be left for some
other time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
