ahuang98 commented on code in PR #17836:
URL: https://github.com/apache/kafka/pull/17836#discussion_r1847005925
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -143,6 +143,9 @@ object StorageTool extends Logging {
if (namespace.getBoolean("standalone")) {
formatter.setInitialControllers(createStandaloneDynamicVoters(config))
}
+ if (namespace.getBoolean("no_initial_controllers")) {
+ formatter.setNoInitialControllers(true)
+ }
Review Comment:
nit: can we change the if statement below into an else clause?
##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########
@@ -130,6 +132,7 @@ public class Formatter {
* The initial KIP-853 voters.
*/
private Optional<DynamicVoters> initialControllers = Optional.empty();
+ private boolean noInitialControllers = false;
Review Comment:
nit: thoughts on calling this `noInitialControllersFlag`? might make it more
clear this is not just set when `initial-controllers` is not supplied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
