jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1847124230
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2() {
assertTrue(transactionManager.isTransactionV2Enabled());
}
+ @Test
+ public void testTransactionV2AddPartitionAndOffsets() throws
InterruptedException {
+ initializeTransactionManager(Optional.of(transactionalId), true);
+ doInitTransactions();
+
+ transactionManager.beginTransaction();
+
+ Future<RecordMetadata> responseFuture = appendToAccumulator(tp0);
+
+ assertFalse(responseFuture.isDone());
+
+ prepareProduceResponse(Errors.NONE, producerId, epoch);
+ assertTrue(transactionManager.transactionContainsPartition(tp0));
+ assertTrue(transactionManager.isSendToPartitionAllowed(tp0));
+ assertFalse(responseFuture.isDone());
+ runUntil(responseFuture::isDone);
+
+ // Now, test adding the offsets.
+ Map<TopicPartition, OffsetAndMetadata> offsets = new HashMap<>();
+ offsets.put(tp1, new OffsetAndMetadata(1));
+
+ TransactionalRequestResult addOffsetsResult =
transactionManager.sendOffsetsToTransaction(
+ offsets, new ConsumerGroupMetadata(consumerGroupId));
+
+ assertTrue(transactionManager.hasPendingOffsetCommits());
+
+ // the result doesn't complete until TxnOffsetCommit returns
Review Comment:
Do we consider the offset partitions added to the transaction before the
response returns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
