chia7712 commented on code in PR #17855:
URL: https://github.com/apache/kafka/pull/17855#discussion_r1847802852
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java:
##########
@@ -520,12 +520,13 @@ public void shouldPutReverseAll() {
final List<KeyValue<Integer, String>> allReturned = new ArrayList<>();
final List<KeyValue<Integer, String>> expectedReturned =
Arrays.asList(KeyValue.pair(2, "two"), KeyValue.pair(1, "one"));
- final Iterator<KeyValue<Integer, String>> iterator =
store.reverseAll();
- while (iterator.hasNext()) {
- allReturned.add(iterator.next());
+ try (final KeyValueIterator<Integer, String> iterator =
store.reverseAll()) {
+ while (iterator.hasNext()) {
Review Comment:
We can reuse `StreamsTestUtils.toList`:
```java
try (final KeyValueIterator<Integer, String> iterator =
store.reverseAll()) {
final List<KeyValue<Integer, String>> allReturned =
StreamsTestUtils.toList(iterator);
final List<KeyValue<Integer, String>> expectedReturned =
Arrays.asList(KeyValue.pair(2, "two"), KeyValue.pair(1,
"one"));
assertThat(allReturned, equalTo(expectedReturned));
}
```
##########
streams/src/test/java/org/apache/kafka/test/StreamsTestUtils.java:
##########
@@ -150,6 +150,17 @@ public static <K, V> Set<V> valuesToSet(final
Iterator<KeyValue<K, V>> iterator)
return results;
}
+ public static <K, V> Set<V> valuesToSetAndCloseIterator(final
KeyValueIterator<K, V> iterator) {
+ try (iterator) {
Review Comment:
We can reuse `valuesToSet`:
```java
try (iterator) {
return valuesToSet(iterator);
}
```
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java:
##########
@@ -501,12 +500,13 @@ public void shouldPutAll() {
final List<KeyValue<Integer, String>> allReturned = new ArrayList<>();
final List<KeyValue<Integer, String>> expectedReturned =
Arrays.asList(KeyValue.pair(1, "one"), KeyValue.pair(2, "two"));
- final Iterator<KeyValue<Integer, String>> iterator = store.all();
- while (iterator.hasNext()) {
- allReturned.add(iterator.next());
+ try (final KeyValueIterator<Integer, String> iterator = store.all()) {
+ while (iterator.hasNext()) {
+ allReturned.add(iterator.next());
Review Comment:
We can reuse `StreamsTestUtils.toList`:
```java
try (final KeyValueIterator<Integer, String> iterator = store.all())
{
final List<KeyValue<Integer, String>> allReturned =
StreamsTestUtils.toList(iterator);
final List<KeyValue<Integer, String>> expectedReturned =
Arrays.asList(KeyValue.pair(1, "one"), KeyValue.pair(2,
"two"));
assertThat(allReturned, equalTo(expectedReturned));
}
```
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java:
##########
@@ -251,7 +250,7 @@ public void shouldPutAndFetch() {
// all records expired as actual from is 59001 and to is 1000
final List<KeyValue<Windowed<String>, Long>> expected =
Collections.emptyList();
- assertEquals(expected, toList(values));
+ assertEquals(expected, toListAndCloseIterator(values));
Review Comment:
line#246 already use try-resource to handle the close, so why does
`toListAndCloseIterator` need to call close again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
