[
https://issues.apache.org/jira/browse/KAFKA-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit updated KAFKA-18027:
----------------------------------
Description:
In reference to PR comment
https://github.com/apache/kafka/pull/17739#discussion_r1844998612 ,the code
seems inaccurate and not aligned with the below comment. I've made the code
change to align it with the comment
> It is possible that an operation is completed after it has been added to the
> watch list for some, but not all the keys. In this case, the operation is
> considered completed and won't be added to the watch list of the remaining
> keys.
was:
In reference to comment
[https://github.com/apache/kafka/pull/17739#discussion_r1844998612] ,the below
comment seems inaccurate. Currently, we add a delayed operation to either all
keys or none of the keys. Nevertheless, the property that onComplete() is only
called once when the operation is not completed still holds. It would be useful
to fix the comment.
{quote}In this case, the operation is considered completed and won't be added
to the watch list of the remaining keys.
{quote}
> MINOR: Correct DelayedOperationPurgatory comment about operation completion
> ---------------------------------------------------------------------------
>
> Key: KAFKA-18027
> URL: https://issues.apache.org/jira/browse/KAFKA-18027
> Project: Kafka
> Issue Type: Bug
> Reporter: Abhinav Dixit
> Assignee: Abhinav Dixit
> Priority: Major
>
> In reference to PR comment
> https://github.com/apache/kafka/pull/17739#discussion_r1844998612 ,the code
> seems inaccurate and not aligned with the below comment. I've made the code
> change to align it with the comment
> > It is possible that an operation is completed after it has been added to
> > the watch list for some, but not all the keys. In this case, the operation
> > is considered completed and won't be added to the watch list of the
> > remaining keys.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
