CalvinConfluent commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1849340745
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -225,7 +245,7 @@ class AddPartitionsToTxnManager(
val code =
if (partitionResult.partitionErrorCode ==
Errors.PRODUCER_FENCED.code)
Errors.INVALID_PRODUCER_EPOCH.code
- else if (partitionResult.partitionErrorCode() ==
Errors.TRANSACTION_ABORTABLE.code &&
transactionDataAndCallbacks.transactionSupportedOperation != genericError) //
For backward compatibility with clients.
+ else if (partitionResult.partitionErrorCode() ==
Errors.TRANSACTION_ABORTABLE.code &&
transactionDataAndCallbacks.transactionSupportedOperation !=
genericErrorSupported) // For backward compatibility with clients.
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
