satishd commented on code in PR #17859:
URL: https://github.com/apache/kafka/pull/17859#discussion_r1850292626
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1167,6 +1167,22 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurable w
throw new ConfigException(s"$errorMsg, value should be at least 1")
}
}
+
+ if
(RemoteLogManagerConfig.REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP.equals(k)
||
+
RemoteLogManagerConfig.REMOTE_LOG_MANAGER_EXPIRATION_THREAD_POOL_SIZE_PROP.equals(k)
||
+ RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP.equals(k)) {
+ val newValue = v.asInstanceOf[Int]
+ val oldValue = server.config.getInt(k)
+ if (newValue != oldValue) {
+ val errorMsg = s"Dynamic thread count update validation failed for
$k=$v"
+ if (newValue <= 0)
Review Comment:
I suggested to keep -1 for falling back to the default value in the original
[PR](https://github.com/apache/kafka/pull/17499/#discussion_r1804119567).
I am fine with the approach of not allowing back to setting default as -1
for the dynamic configuration. Please add a java doc comment and also add a
clear message in the exception for user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
