mimaison commented on code in PR #17880:
URL: https://github.com/apache/kafka/pull/17880#discussion_r1850681333
##########
tools/src/test/java/org/apache/kafka/tools/AclCommandTest.java:
##########
@@ -303,7 +294,7 @@ public void
testUseBootstrapServerOptWithBootstrapControllerOpt() {
@Test
public void testUseWithoutBootstrapServerOptAndBootstrapControllerOpt() {
assertInitializeInvalidOptionsExitCodeAndMsg(
- Collections.emptyList(),
+ Collections.singletonList(ADD),
Review Comment:
Actually if you don't provide any arguments on the CLI, just the help
message is printed.
The previous test was expecting a different behavior as
`maybePrintHelpOrVersion()` used to be called in `main()` while I moved it to
`AclCommandOptions.checkArgs()` for consistency with the other tools, and
consistency with the CLI behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
