tinaselenge commented on code in PR #17524:
URL: https://github.com/apache/kafka/pull/17524#discussion_r1850837344
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2554,6 +2557,10 @@ boolean handleUnsupportedVersionException(final
UnsupportedVersionException exce
return false;
}
+ if (exception.getMessage().contains("Including fenced broker
endpoints is not supported with version")) {
+ return false;
+ }
+
useMetadataRequest = true;
return true;
Review Comment:
Thanks Luke for reviewing the PR. I'm not quite sure on this. We fallback to
metadata request, if the broker does not support the new DescribeCluster API.
In this case, DescribeCluster API is supported but the option to include fenced
broker is not. So this is why we are checking the specific error message to
differentiate the cause of UnsupportedVersion exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
