bbejeck commented on code in PR #17856:
URL: https://github.com/apache/kafka/pull/17856#discussion_r1852397860
##########
streams/src/main/java/org/apache/kafka/streams/errors/BrokerNotFoundException.java:
##########
@@ -16,13 +16,13 @@
*/
package org.apache.kafka.streams.errors;
-
/**
* Indicates that none of the specified {@link
org.apache.kafka.streams.StreamsConfig#BOOTSTRAP_SERVERS_CONFIG brokers}
* could be found.
*
* @see org.apache.kafka.streams.StreamsConfig
*/
+@SuppressWarnings("unused")
Review Comment:
I'm not a big fan of adding this, but I get why we'd do so
##########
streams/src/main/java/org/apache/kafka/streams/errors/ProductionExceptionHandler.java:
##########
@@ -56,10 +66,16 @@ default ProductionExceptionHandlerResponse handle(final
ErrorHandlerContext cont
* Handles serialization exception and determine if the process should
continue. The default implementation is to
* fail the process.
*
- * @param record the record that failed to serialize
- * @param exception the exception that occurred during serialization
+ * @param record
+ * The record that failed to serialize.
+ * @param exception
+ * The exception that occurred during serialization.
+ *
+ * @return Whether to continue or stop processing, or retry the failed
operation.
+ *
* @deprecated Since 3.9. Use {@link
#handleSerializationException(ErrorHandlerContext, ProducerRecord, Exception,
SerializationExceptionOrigin)} instead.
*/
+ @SuppressWarnings({"rawtypes", "unused"})
Review Comment:
instead of using `rawtypes` it could be `ProducerRecord<?, ?>` but it's up
to you
##########
streams/src/main/java/org/apache/kafka/streams/errors/ProductionExceptionHandler.java:
##########
@@ -70,11 +86,18 @@ default ProductionExceptionHandlerResponse
handleSerializationException(final Pr
* Handles serialization exception and determine if the process should
continue. The default implementation is to
* fail the process.
*
- * @param context the error handler context metadata
- * @param record the record that failed to serialize
- * @param exception the exception that occurred during serialization
- * @param origin the origin of the serialization exception
+ * @param context
+ * The error handler context metadata.
+ * @param record
+ * The record that failed to serialize.
+ * @param exception
+ * The exception that occurred during serialization.
+ * @param origin
+ * The origin of the serialization exception.
+ *
+ * @return Whether to continue or stop processing, or retry the failed
operation.
*/
+ @SuppressWarnings("rawtypes")
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
