AndrewJSchofield commented on code in PR #17917:
URL: https://github.com/apache/kafka/pull/17917#discussion_r1854356702
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -320,11 +320,12 @@ private void process(final
TopicPatternSubscriptionChangeEvent event) {
* This will make the consumer send the updated subscription on the next
poll.
*/
private void process(final UpdatePatternSubscriptionEvent event) {
+ if (!subscriptions.hasPatternSubscription()) {
Review Comment:
Is this test really necessary? This event is only sent if the application
thread knows there's a pattern subscription.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
