junrao commented on code in PR #17886:
URL: https://github.com/apache/kafka/pull/17886#discussion_r1854475684
##########
server-common/src/test/java/org/apache/kafka/server/common/FeaturesTest.java:
##########
@@ -115,8 +115,8 @@ public void testDefaultValueAllFeatures(Features feature) {
@ParameterizedTest
@EnumSource(Features.class)
- public void testLatestProductionMapsToLatestMetadataVersion(Features
features) {
- assertEquals(features.latestProduction(),
features.defaultValue(MetadataVersion.LATEST_PRODUCTION));
+ public void testLatestProductionIsNotBehindLatestMetadataVersion(Features
features) {
Review Comment:
We can keep this test. But this test only covers one of the three conditions
in `Features.validateDefaultValueAndLatestProductionValue`. If we are worried
about code changes, should we have tests covering other conditions too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
