ShivsundarR commented on code in PR #17909:
URL: https://github.com/apache/kafka/pull/17909#discussion_r1854555948
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -421,6 +421,10 @@ public void onComplete(Map<TopicIdPartition, Set<Long>>
offsetsMap, Exception ex
Set<Long> mergedOffsets = new HashSet<>();
mergedOffsets.addAll(oldOffsets);
mergedOffsets.addAll(newOffsets);
+ if (mergedOffsets.size() < (oldOffsets.size() +
newOffsets.size())) {
Review Comment:
Ah right makes sense, sometimes genuinely we can have the callback called
twice. I have removed it now, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
