brandboat opened a new pull request, #17932:
URL: https://github.com/apache/kafka/pull/17932

   related to KAFKA-18083, 
   
   this is something missed in 
https://issues.apache.org/jira/browse/KAFKA-17721, plenty of places are still 
use hardcoded "CONTROLLER" controller listener name ans cause 
`controllerListener` property not work.
   e.g.
   1. 
https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L172
   2. 
https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L392
   3. 
https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L403
   
   and we should add corresponding test case in ClusterTestExtensionsTest.java
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to