FrankYang0529 commented on code in PR #17199:
URL: https://github.com/apache/kafka/pull/17199#discussion_r1858310870
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java:
##########
@@ -42,26 +44,32 @@
public class ApplicationEventHandler implements Closeable {
private final Logger log;
+ private final Time time;
private final BlockingQueue<ApplicationEvent> applicationEventQueue;
Review Comment:
I think `ApplicationEventHandler` is a class to encapsulate application
event queue. However, it couples with `ConsumerNetworkThread`, so we can't just
add the draining event function to `ApplicationEventHandler`. How about we
solve it in followup Jira https://issues.apache.org/jira/browse/KAFKA-18048? We
had related discussion in previous comment
https://github.com/apache/kafka/pull/17199#discussion_r1849058419.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
